Skip to content

Consider deleting the unreviewed revisions if the revision author was deleted #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emilghittasv opened this issue Feb 28, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@emilghittasv
Copy link
Collaborator

emilghittasv commented Feb 28, 2025

Preconditions
Sign in to SUMO

Steps to reproduce
Steps to reproduce the behavior:

The unreviewed revision is the first revision of the kb article (document is not live yet)

  1. Go to https://support.allizom.org/en-US/kb/new
  2. Create a new kb article without approving it's first revision.
  3. Navigate to the https://accounts.stage.mozaws.net page and initiate the user deletion.

The unreviewed revision is not the first revision

  1. Go to a KB article which has multiple revisions.
  2. Create a new revision (do not approve it)
  3. Navigate to the https://accounts.stage.mozaws.net page and initiate the user deletion.

Expected behavior

For the case in which the unreviewed revision is the first revision

  • The entire KB article is deleted since the kb article is not live and contains only the first revision which was not approved.

For the case in which the unreviewed revision is not the first revision

  • The unreviewed revision is deleted.

Actual behavior

  • For both cases, the unreviewed revision is moved under the SumoBot.

Desktop:

  • OS: Windows 11
  • Browser: Firefox

Additional context
This issue is reproducible in stage

@emilghittasv emilghittasv added the bug Something isn't working label Feb 28, 2025
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Feb 28, 2025
@emilghittasv emilghittasv moved this from ❓ triage to 🗄 backlog in Mozilla Support Feb 28, 2025
@emilghittasv emilghittasv changed the title Consider deleting the entire KB article if the only revision available for that document is unreviewed and the author account was deleted Consider deleting the unreviewed revisions if the revision author was deleted Mar 17, 2025
@emilghittasv emilghittasv moved this from 🗄 backlog to 🚀 in progress in Mozilla Support Mar 17, 2025
@akatsoulas
Copy link
Collaborator

PR mozilla/kitsune#6567

@akatsoulas akatsoulas moved this from 🚀 in progress to 📚 review in Mozilla Support Mar 17, 2025
@emilghittasv emilghittasv moved this from 📚 review to 🔎 QA in Mozilla Support Mar 18, 2025
@emilghittasv
Copy link
Collaborator Author

I can confirm that both cases mentioned in this ticket are verified fixed in stage.

Moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Mar 18, 2025
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants